Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert HierarchyQueryExt to use a SystemParam instead of an extension trait #15670

Open
alice-i-cecile opened this issue Oct 5, 2024 · 1 comment
Open

Convert HierarchyQueryExt to use a SystemParam instead of an extension trait #15670

alice-i-cecile opened this issue Oct 5, 2024 · 1 comment
Labels
C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@alice-i-cecile
Copy link
Member

I wonder if it would be a good idea to convert HierarchyQueryExt into system params instead 🤔 what is the reason it is an extension in the first place?

I'm pretty sure it predates the SystemParam derive macro, and has grown organically from there. I really like the filtering capabilities, but I agree: I think that the SystemParam approach is a lot simpler as both a user and a maintainer. Adding a filter generic should be totally doable. Follow-up though!

Originally posted by @alice-i-cecile in #15627 (comment)
@ItsDoot
Copy link
Contributor

ItsDoot commented Oct 6, 2024

This would be a great followup to #15635, to provide a more generic traversal SystemParam.

@ItsDoot ItsDoot added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Hierarchy D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes labels Oct 6, 2024
@villor villor mentioned this issue Oct 12, 2024
Open
@BenjaminBrienen BenjaminBrienen added the S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! label Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alice-i-cecile @ItsDoot @BenjaminBrienen