Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert GhostNode changes for now #15732

Closed
alice-i-cecile opened this issue Oct 8, 2024 · 1 comment
Closed

Revert GhostNode changes for now #15732

alice-i-cecile opened this issue Oct 8, 2024 · 1 comment
Assignees
@alice-i-cecile
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use
Milestone
0.15

Comments

@alice-i-cecile
Copy link
Member

Having thought on this, I think the path forward is removing GhostNode and making replacing the no UI->NonUI layout constraint with a no UI->NonUi->UI constraint. Then we unify on a single TextSpan type as it can be a non-ui contextless component.

This is fine with me, but changing the layout algorithm should not be part of this PR. Can you open a new PR supporting the changes you want? Then I will rebase once that's merged and consolidate the span types.

Originally posted by @UkoeHB in #15591 (comment)
@alice-i-cecile alice-i-cecile self-assigned this Oct 8, 2024
@alice-i-cecile alice-i-cecile added A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Oct 8, 2024
@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Oct 8, 2024
@alice-i-cecile
Copy link
Member Author

Specifically this from cart’s comment: “replacing the no UI->NonUI layout constraint with a no UI->NonUi->UI constraint”. Currently layout warns if you don’t have Node on everything in the hierarchy (or GhostNode). We want to loosen it so leaf entities don’t warn (but interstitial entities still warn).

@alice-i-cecile alice-i-cecile closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alice-i-cecile alice-i-cecile

Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
0.15
Development

No branches or pull requests
1 participant
@alice-i-cecile