Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for RenderPass that renders to WindowSwapChain before MainPass #3190

Closed
KirmesBude opened this issue Nov 25, 2021 · 0 comments
Closed
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use

Comments

@KirmesBude
Copy link
Contributor

KirmesBude commented Nov 25, 2021

What problem does this solve or what need does it fill?

I want to add a RenderPassthat renders to WindowSwapChain before MainPass.
This currently does not seem possible because of the Operation defined in the PassDescriptor of MainPass, that clears the color attachment.
https://github.com/bevyengine/bevy/blob/main/crates/bevy_render/src/render_graph/base.rs#L141

What solution would you like?

Clearing the color_attachment should be its own pass before MainPass, so users can add their own passes before MainPass.

What alternative(s) have you considered?

Alternatively there could be a way to change the Operation/PassDescriptor of MainPass at runtime or during initial creation (by way of parameter to RenderPlugin)

Additional context

You can fínd my attempt at adding a RenderPass before MainPass here: https://github.com/KirmesBude/bevy_background
Minimal example including a RenderGraph svg dump.

Edit: The issue exsits on 0.6, but the proposed solutions are different.

@KirmesBude KirmesBude added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Nov 25, 2021
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use and removed C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Nov 25, 2021
@bors bors bot closed this as completed in 82c04f9 Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants