-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The examples readme doesn't explain how to run the examples properly #472
Comments
This should be closed in light of #471 merging |
Good call! |
Actually wait this seems like a separate issue. That pr fixes a broken command. This issue points out that assets only work correctly when run from the project root. |
Oh gotcha gotcha. I can work on fixing that; we probably only need to add env!("CARGO_MANIFEST_DIR") to the asset paths. |
Huh... I don't if we would want to use the root path in case the user wants to load from an arbitrary directory, but also I don't know if the asset server is intended to be used with a single asset directory. That would make the most sense from a usage perspective at least; a change in Not sure if you were implying that we might want to change |
I think we actually want well-defined (or at least scoped) asset paths, as some platforms require that. I think its natural to restrict loads to the root path. |
That makes sense. I'll can whip up a PR pretty soon here. |
This is great. At first I just had a change to the README in mind, but this fix is much better! |
The readme is missing the information that you need to run the cargo commands from the project root.
I found this out because even though the
sprite
example runs when running cargo from the examples directory, it doesn't actually display the sprite because the relative path is from the project root, so it needs to be run from the project root.It would be great if this could be explained in the examples README.
The text was updated successfully, but these errors were encountered: