Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components type stores resource information as well, which is confusing #7289

Open
alice-i-cecile opened this issue Jan 20, 2023 · 2 comments
Open

Components type stores resource information as well, which is confusing #7289

alice-i-cecile opened this issue Jan 20, 2023 · 2 comments
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use

Comments

@alice-i-cecile
Copy link
Member 

          > T_T `Components::resource_id`. Good PR though.

Yeah, I think Components and ComponentId need to renamed, or at least add a ResourceId to solve the latter.

Originally posted by @JonahPlusPlus in #7284 (comment)
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Jan 20, 2023
@JonahPlusPlus
Copy link
Contributor

Maybe rename ComponentInfo to ContentInfo or ContentMeta, since components and resources form the contents of the world? Then Components could be renamed to ContentInfos or ContentMetas, which reflects that it stores a Vec<ComponentInfo>. Renaming it to Contents would lead to confusion with Storages.

Otherwise, there are alternatives like Property, Data, etc.

@alice-i-cecile
Copy link
Member Author

Content is my favorite, but Data is good too. Agreed that Components needs another name: it's too general for how niche the actual type is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alice-i-cecile @JonahPlusPlus