Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add panicking system test to bevy_ecs #7434

Open
alice-i-cecile opened this issue Jan 31, 2023 · 3 comments
Open

Add panicking system test to bevy_ecs #7434

alice-i-cecile opened this issue Jan 31, 2023 · 3 comments
Labels
A-ECS Entities, components, systems, and events A-Tasks Tools for parallel and async work C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@alice-i-cecile
Copy link
Member

The panic_when _hierarchy_cycle test and other similar panicking tests have caught a large number of issues in our tasks and scheduling code.

We should have a test in bevy_ecs with the should_panic annotation that runs a system that panics.

We may also want to add one to bevy_render that panics on the rendering app.
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change A-Tasks Tools for parallel and async work labels Jan 31, 2023
@bjrnt bjrnt mentioned this issue Feb 3, 2023
Closed
@bors bors bot closed this as completed in 6506ea4 Feb 3, 2023
@hymm
Copy link
Contributor

hymm commented Feb 3, 2023

I'm don't think the test in the PR would have caught the miri error. We should probably have a system that is trying to access the world too in the test..

@james7132
Copy link
Member

Can you share which miri error that caused this?

@james7132 james7132 reopened this Feb 4, 2023
@hymm
Copy link
Contributor

hymm commented Feb 5, 2023 •
edited
Loading

this was the original issue for the miri error #6603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events A-Tasks Tools for parallel and async work C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Add unit test with system that panics
3 participants
@hymm @james7132 @alice-i-cecile