SparseSet components cause incorrect Query output

[hankjordan]

Bevy version

#41fec57

What you did

Not present in 0.9, but is at least as old as commit #943499.

It can be triggered by spawning many entities (10,000?) with both Table and SparseSet components and inserting / removing SparseSet components quickly

The bug manifests itself by messing with query results, returning incorrect values for a given entity.
These values are valid, just not for the Entity I am querying for.

The bug disappears when I switch all of the components to use Table storage.

Here is a log from my game.
I never update the components Transform or ChunkPos for these entities, it's only set once when the entity is spawned.
Note that the entity is the same in each tick, I am checking the same Entity and have disabled despawning:

INFO world2: Check: 6676v0 - Transform { translation: Vec3(0.0, 0.0, 0.0), rotation: Quat(0.0, 0.0, 0.0, 1.0), scale: Vec3(1.0, 1.0, 1.0) } - ChunkPos { x: 0, y: 0, z: 0 }
INFO world2: Check: 6676v0 - Transform { translation: Vec3(0.0, 0.0, 0.0), rotation: Quat(0.0, 0.0, 0.0, 1.0), scale: Vec3(1.0, 1.0, 1.0) } - ChunkPos { x: 0, y: 0, z: 0 }
INFO world2: Check: 6676v0 - Transform { translation: Vec3(0.0, 0.0, 0.0), rotation: Quat(0.0, 0.0, 0.0, 1.0), scale: Vec3(1.0, 1.0, 1.0) } - ChunkPos { x: 0, y: 0, z: 0 }
INFO world2: Check: 6676v0 - Transform { translation: Vec3(240.0, 128.0, 32.0), rotation: Quat(0.0, 0.0, 0.0, 1.0), scale: Vec3(1.0, 1.0, 1.0) } - ChunkPos { x: 15, y: 8, z: 2 }
INFO world2: Check: 6676v0 - Transform { translation: Vec3(144.0, 64.0, -16.0), rotation: Quat(0.0, 0.0, 0.0, 1.0), scale: Vec3(1.0, 1.0, 1.0) } - ChunkPos { x: 9, y: 4, z: -1 }

What went wrong

• Query::get returned unexpectedly changed values, when no part of the code is actually modifying the values

Additional Information

• The SparseSet components are ZST
• No repro yet, sorry

[hankjordan]

Appears to be fixed by #7805