Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to LUT-less tonemapping if compiled without tonemapping_luts #9131

Closed
yyogo opened this issue Jul 12, 2023 · 1 comment
Closed

Fallback to LUT-less tonemapping if compiled without tonemapping_luts #9131

yyogo opened this issue Jul 12, 2023 · 1 comment
Labels
C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled

Comments

@yyogo
Copy link
Contributor

yyogo commented Jul 12, 2023

What problem does this solve or what need does it fill?

Programs compiled without default features (specifically without tonemapping_luts) are now broken in runtime when not explicitly specifying a tone mapping method. This is especially confusing when migrating from pre-0.11 and is hard to figure out from the migration guide.

What solution would you like?

When using a tone mapping method that requires LUTs, but compiled without LUTs, write a warning and fall back to a different tone mapping method (or disable tone mapping altogether).

What alternative(s) have you considered?

  • Add a tonemapping_fallback option that only includes LUT-less options.
  • Add a Tonemapping::TonyMcMapfaceWithFallback variant as the new default, and have it fallback to ReinhardLuminance
  • Generate a compile-time warning or error when compiling without LUTs and choosing a tonemapping that requires it
  • Do nothing, make users fix their code, document this in the migration guide.

Additional context

@yyogo yyogo added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Jul 12, 2023
@yyogo yyogo changed the title Fallback to LUT-less tonemapping if compliled without tonemapping_luts Fallback to LUT-less tonemapping if compiled without tonemapping_luts Jul 12, 2023
@yyogo
Copy link
Contributor Author

yyogo commented Jul 12, 2023

Duplicate of #9098; closing

@yyogo yyogo closed this as completed Jul 12, 2023
@nicopap nicopap closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled
Projects
None yet
Development

No branches or pull requests

2 participants