-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish on itch.io as part of the tag release workflow #13
Publish on itch.io as part of the tag release workflow #13
Conversation
@@ -34,6 +34,8 @@ It will build: | |||
|
|||
If you don't want to target some of those platforms, you can remove the corresponding job from the file [release.yaml](./.github/workflows/release.yaml). | |||
|
|||
If you don't want to attach the builds to the GitHub release, set `env.add_binaries_to_github_release` to `false`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could use a bit more detail on how exactly this is done; the target audience is novice programmers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can put before&after of the relevant YAML section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That may be more confusing.
I think just explaining in more descriptive way how you don't need to store binaries on GitHub to get them on Itch would be enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So... move this to the new ### Publish on itch.io
section (which already requires that you touch env
) and explain it at that context?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a new section ### Publish on GitHub release
could be nice and mirror the new ### Publish on itch.io
(and would be easy to expand if we add more targets later, an easy one would be a publish to GitHub page
with a custom html and/or the wasm version for example)
Tested this and it seems to generally work. Something mildly interesting seems to be happening with the mac builds. It seems like they are getting uploaded with a On my "edit game" page, I see Haven't looked too deep at this. I've never used butler so I don't really know what's going on. |
while a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for me on the workflow
This replaces #12