Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish on itch.io as part of the tag release workflow #13

Conversation

idanarye
Copy link
Contributor

@idanarye idanarye commented Sep 6, 2022

This replaces #12

@@ -34,6 +34,8 @@ It will build:

If you don't want to target some of those platforms, you can remove the corresponding job from the file [release.yaml](./.github/workflows/release.yaml).

If you don't want to attach the builds to the GitHub release, set `env.add_binaries_to_github_release` to `false`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could use a bit more detail on how exactly this is done; the target audience is novice programmers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can put before&after of the relevant YAML section?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That may be more confusing.
I think just explaining in more descriptive way how you don't need to store binaries on GitHub to get them on Itch would be enough.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So... move this to the new ### Publish on itch.io section (which already requires that you touch env) and explain it at that context?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a new section ### Publish on GitHub release could be nice and mirror the new ### Publish on itch.io
(and would be easy to expand if we add more targets later, an easy one would be a publish to GitHub page with a custom html and/or the wasm version for example)

@rparrett
Copy link
Contributor

rparrett commented Sep 7, 2022

Tested this and it seems to generally work.

Something mildly interesting seems to be happening with the mac builds. It seems like they are getting uploaded with a .zip extension rather than .dmg, and then butler is "correcting" that and while doing so, changing the filename.

On my "edit game" page, I see pixie-wrangler-mac.zip, but a player downloading the game sees pixie_wrangler.dmg. The file does seem to work though. But I don't like the way the name is getting clobbered (-mac goes missing, and the hyphen becomes an underscore)

Haven't looked too deep at this. I've never used butler so I don't really know what's going on.

@mockersf
Copy link
Member

mockersf commented Sep 7, 2022

while a .dmg file is the most common way to deliver an app on macOS, itch.io doesn't handle that very well (for example, it won't really work in the itch.io app). I still think it's the better option

Copy link
Member

@mockersf mockersf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me on the workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants