Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltips for join-queue and leave-queue and use them in non-singleplayer rooms #355

Merged
merged 3 commits into from
Apr 16, 2023
Merged

Conversation

AntlerForce
Copy link
Collaborator

Also do not say $leaveq in singleplayer games.

Copy link
Collaborator

@FIr3baL FIr3baL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • looks good to me
  • this PR is extending Play/Spectate button reactions correctly for singleplayer games, which i never test that much, thank you :)
  • tested with singleplayer and multiplayer

I´ll make some follow-up changes:

  1. in multiplayer the "play"-button not necessary stands for "join-queue" - but only, when all teams are full, otherwise it´s a real play-button
  2. Nothing to do with this PR, but Play button should become "active", when we are on queue, because more "play" is not possible than being in the join-queue already; currently the play button becomes active, when we really got a seat in the playerlist

@FIr3baL
Copy link
Collaborator

FIr3baL commented Apr 16, 2023

And i wasn't aware, that i'm using the wrong apostrophe for english all the time. On german keyboard we can access the "acute, backtick or left quote" [´] directly, while the apostrophe ['] needs Shift+#
Lessons learned :)

@FIr3baL FIr3baL merged commit 0e7ad96 into beyond-all-reason:master Apr 16, 2023
@AntlerForce AntlerForce deleted the antlertest branch April 25, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants