Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/page transition fix #271

Conversation

Mark104
Copy link
Contributor

@Mark104 Mark104 commented Sep 25, 2024

Vue update to latest version and a fix for the page transition issue the lobby has been experiencing for a while. This issue has a bit of history to it by the looks of it from #61 #179 #248 and the intent is for this PR to solve this.

This requires a merge of #270 PR first as I've had to base this branch off those changes to allow for testing.

Issue:

  • Changing tabs would show a styling issue (where the content of the previous page was shown for a short period and the new content shifted to the bottom).
  • This was caused by a workaround to fix a bigger issue, whereby switching pages very fast would sometimes throw a critical issue and break the client.
  • A part of this issue was due to a Vue internal issue. This was highlighted to the Vue team by @Jazcash and the workaround used till the team implemented a fix.

Proposed fix:

  • Updating to the latest Vue version that should include fixes to this issue.
  • Testing the site to ensure that upgrading the vue version did not cause any build issues. This appears to be fine.
  • This exposed that actually Vue crash related to Suspense + Transition + RouterView + Teleport #179 was a different issue, related to using an await in a component setup. Therefore I've moved this code to a onMounted function which appears to solve the issue.

Results in:

  • No styling issues when transitioning between pages.
  • No observed critical errors when changing lots of tabs really quickly.

…vent immediate drop due to "Server sent no subprotocol".
…mented battle as error caused issues with router.
…on issue in beyond-all-reason#61 & beyond-all-reason#179 & beyond-all-reason#248).  Moved await in ranked setup to onMounted and added opt-in back in.

Seems to me that also a part of this is that we're awaiting in component setups. Far as I understand the lifecycle, we should be using onMounted to do such things or rather maybe Vue prefers we do.
@Mark104
Copy link
Contributor Author

Mark104 commented Oct 3, 2024

Closing this PR for. We've got alot of things to fix to get this passing the checks again (such as the seperate tachyon-client). Will get this and other PRS merged into a single branch and then start to look to fix the branch to pass these checks.

Sorry for any time wasted, but just looking to get this merged in when its stable and passing.

@Mark104 Mark104 closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants