Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[update] get_balance_of #6

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[update] get_balance_of #6

wants to merge 1 commit into from

Conversation

kichinosukey
Copy link

@ks91
Copy link
Collaborator

ks91 commented May 14, 2019

Thank you very much for your contribution.
I think that the proposed functionality should be called something other than "get_balance_of" (which implies return of a single quantity), and I will consider how to incorporate your proposal into the library.
I will also write tests.

@kichinosukey
Copy link
Author

I agree your opinion since I feel the name of "get_balance_of" is not appropriate.Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kichinosukey @ks91