-
Notifications
You must be signed in to change notification settings - Fork 128
Laravel 10.x Compatibility #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch. To do so, temporarily add Shift's fork to the {
"repositories": [
{
"type": "vcs",
"url": "https://github.com/laravel-shift/laravel-mailbox.git"
}
]
} Then update your dependency constraint to reference this branch: {
"require": {
"beyondcode/laravel-mailbox": "dev-l10-compatibility",
}
} Finally, run: |
@mpociot This PR looks like it could contain all that's needed to support Laravel 10.x, based on a review of the changes that were made to support L9.x. Could this be merged soon and a new version tagged? |
My fork adds support for Laravel 10 while we are waiting for the official package to update. |
composer.json
Outdated
"illuminate/routing": "^6.0|^7.0|^8.0|^9.0|^10.0", | ||
"illuminate/support": "^6.0|^7.0|^8.0|^9.0|^10.0", | ||
"willdurand/email-reply-parser": "^2.8", | ||
"zbateson/mail-mime-parser": "^1.1|^2.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mpociot What's the conflict/issue with mail-mime-parser 2.x ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wanted to handle this in a separate PR and likely drop support for 1.x versions of the mime parser at the same time 👍
This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.
Before merging, you need to:
l10-compatibility
branchIf you do find an issue, please report it by commenting on this PR to help improve future automation.