Skip to content

Conversation

laravel-shift
Copy link
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.

Before merging, you need to:

  • Checkout the l10-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Contributor Author

⚠️ Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 10. However, you should review these changes to ensure the desired combination of versions are built for your package.

@laravel-shift
Copy link
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/laravel-mailbox.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "beyondcode/laravel-mailbox": "dev-l10-compatibility",
    }
}

Finally, run: composer update

@jonnott
Copy link

jonnott commented Feb 16, 2023

@mpociot This PR looks like it could contain all that's needed to support Laravel 10.x, based on a review of the changes that were made to support L9.x.

Could this be merged soon and a new version tagged?

@siebsie23
Copy link

@mpociot This PR looks like it could contain all that's needed to support Laravel 10.x, based on a review of the changes that were made to support L9.x.

Could this be merged soon and a new version tagged?

My fork adds support for Laravel 10 while we are waiting for the official package to update.

@mpociot mpociot merged commit 8353dcb into beyondcode:master Feb 21, 2023
composer.json Outdated
"illuminate/routing": "^6.0|^7.0|^8.0|^9.0|^10.0",
"illuminate/support": "^6.0|^7.0|^8.0|^9.0|^10.0",
"willdurand/email-reply-parser": "^2.8",
"zbateson/mail-mime-parser": "^1.1|^2.3"
Copy link

@jonnott jonnott Feb 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpociot What's the conflict/issue with mail-mime-parser 2.x ?

Copy link
Member

@mpociot mpociot Feb 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wanted to handle this in a separate PR and likely drop support for 1.x versions of the mime parser at the same time 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants