Do not log if no valid sources are found in backtrace #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return if no sources are found.
emirhanbalkac
approved these changes
Dec 7, 2022
hediyebiyik
approved these changes
Feb 13, 2023
ufukugurkb
approved these changes
Feb 13, 2023
Closed
|
@mpociot Any chances for merging this PR? This is a simple fix for a bug that can cause random crashes in dev environments. |
|
Can you merge this PR? It is very important for me. Thanks. |
|
Any update about merging this? Thanks :) |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #91. When the backtrace results are filtered through
findSource, they can return an empty array.Currently if the array is empty, an error is thrown as the zero key in
$sourcesis not found.This checks to see if the array is empty, if so, it simply returns from the log.
This PR may be a bit naïve in that I am not able to determine which use cases the backtrace is returning empty. There may be a deeper issue at play, however this returns before the error and allows the app to continue to function.
I also do not have a good way to test this, so if someone would like to add a test, feel free.