RN-635: Added warnings about manual analytics refreshes where it's be…

…ing done
beyondessential · Sep 2, 2022 · 19dff97 · 19dff97
1 parent e3f19e1
commit 19dff97
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/packages/central-server/src/apiV2/postChanges.js b/packages/central-server/src/apiV2/postChanges.js
@@ -69,6 +69,8 @@ export async function postChanges(req, res) {
     await ACTION_HANDLERS[action](models, translatedPayload);
 
     if (action === SUBMIT_SURVEY_RESPONSE) {
+      // TODO: Rework this functionality, as directly calling an analytics refresh here is both inefficient
+      // and may create duplicate records in the analytics table
       const { waitForAnalyticsRebuild } = rest;
       if (waitForAnalyticsRebuild) {
         const { database } = models;

diff --git a/packages/central-server/src/apiV2/surveyResponses/DeleteSurveyResponses.js b/packages/central-server/src/apiV2/surveyResponses/DeleteSurveyResponses.js
@@ -38,6 +38,8 @@ export class DeleteSurveyResponses extends DeleteHandler {
     await super.deleteRecord();
 
     if (this.req.query.waitForAnalyticsRebuild === 'true') {
+      // TODO: Rework this functionality, as directly calling an analytics refresh here is both inefficient
+      // and may create duplicate records in the analytics table
       const { database } = this.models;
       await AnalyticsRefresher.refreshAnalytics(database);
     }