Update task assignee question validation

beyondessential · Aug 28, 2024 · a2b0e99 · a2b0e99
1 parent 96c75be
commit a2b0e99
Showing 1 changed file with 17 additions and 1 deletion.
diff --git a/...al-server/src/apiV2/import/importSurveys/Validator/ConfigValidator/TaskConfigValidator.js b/...al-server/src/apiV2/import/importSurveys/Validator/ConfigValidator/TaskConfigValidator.js
@@ -18,7 +18,7 @@ export class TaskConfigValidator extends JsonFieldValidator {
   getFieldValidators(rowIndex) {
     const referencesExistingSurvey = this.constructReferencesExistingSurvey();
 
-    const pointsToAnotherQuestion = this.constructPointsToAnotherQuestion(rowIndex);
+    const pointsToAnotherQuestion = this.constructReferencesPreceedingQuestion(rowIndex, ['User']);
 
     return {
       shouldCreateTask: [this.constructReferencesPreceedingMandatoryQuestion(rowIndex, ['Binary'])],
@@ -47,6 +47,22 @@ export class TaskConfigValidator extends JsonFieldValidator {
     };
   };
 
+  constructReferencesPreceedingQuestion = (rowIndex, acceptedQuestionTypes) => {
+    return value => {
+      const question = this.findOtherQuestion(value, rowIndex, rowIndex);
+      if (!question) {
+        throw new ValidationError('Referenced question does not exist');
+      }
+
+      if (!acceptedQuestionTypes.includes(question.type)) {
+        throw new ValidationError(
+          `Referenced question should be of type ${acceptedQuestionTypes.join(' or ')}`,
+        );
+      }
+      return true;
+    };
+  };
+
   constructReferencesPreceedingMandatoryQuestion = (rowIndex, acceptedQuestionTypes) => {
     return value => {
       const question = this.findOtherQuestion(value, rowIndex, rowIndex);