MAUI-859: Enable Project Creation #4036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have also realised that I should write up a unit test, which I have not done yet. |
IgorNadj
suggested changes
Jul 22, 2022
packages/central-server/src/apiV2/utilities/constructNewRecordValidationRules.js
Show resolved
Hide resolved
packages/central-server/src/apiV2/utilities/constructNewRecordValidationRules.js
Show resolved
Hide resolved
packages/central-server/src/apiV2/utilities/constructNewRecordValidationRules.js
Outdated
Show resolved
Hide resolved
|
@IgorNadj this is ready to review again. Note that there is no specific rollback unit test. |
IgorNadj
reviewed
Aug 11, 2022
|
|
||
| async createProjectEntityRelations(models, code, countries) { | ||
| const { id: projectEntityId } = await models.entity.findOne({ | ||
| 'entity.code': code, |
There was a problem hiding this comment.
Minor: you don't need to prefix things here, you can just do { code: code }, same with others below
| }); | ||
| } | ||
|
|
||
| async createProjectEntityRelations(models, code, countries) { |
There was a problem hiding this comment.
Suggest we rename code argument to projectCode? Took me a little bit of time to figure out what this was
| const worldCode = 'World'; | ||
| const { id: worldId } = await models.entity.findOne({ 'entity.code': worldCode }); | ||
|
|
||
| await models.entity.create({ |
There was a problem hiding this comment.
Minor: .create() returns the record with an id, so you can return that instead of querying again to get it above on line 42. Same with the others
IgorNadj
approved these changes
Aug 11, 2022
|
Thanks for the feedback @IgorNadj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue MAUI-859:
Changes:
Screenshots: