Rn 588 data broker tei #4045
Merged
Rn 588 data broker tei #4045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmofro
requested changes
Jul 28, 2022
| @@ -32,11 +32,12 @@ const mockFind = (array, criteria = {}) => | |||
|
|
|||
| if (key.includes('->>')) { | |||
| // Special case | |||
| const lookupPath = key.split('->>'); | |||
| if (lookupPath.length > 2) throw new Error('Not implemented yet...'); | |||
| @@ -0,0 +1,3 @@ | |||
| export const addTrackedEntityCodes = async (models, events) => { | |||
| return events; | |||
| }; | |||
There was a problem hiding this comment.
Ah didn't spot this in my once-over, removed
| * Data pulls sometimes return tracked entity instance ids. This translator | ||
| * converts these ids to entity codes. | ||
| */ | ||
| export class TrackedEntityInstanceTranslator { |
edmofro
approved these changes
Jul 28, 2022
| * It detects such instances, and swaps all the codes it is given to ids for the fetch, then does the same for | ||
| * the data coming back (swapping ids in the response data for codes). | ||
| */ | ||
| export class DhisCodeToIdTranslator { |
There was a problem hiding this comment.
Huge name improvement, and great comment above
| import { expect } from 'chai'; | ||
| import { createModelsStub } from '../../testUtilities'; | ||
|
|
||
| describe('createModelsStub', () => { |
| * @param {MockData} mockData | ||
| * @return {} a partial implementation of ModelRegistry, to be used in its place | ||
| */ | ||
| export const createModelsStub = mockData => { |
Goodbye terribly long name...
IgorNadj
force-pushed
the
rn-588-data-broker-tei
branch
from
d76455e to
1cfb222
Compare
|
Rebased on master so we can deploy this separately as a hotfix, the only commits that were dropped out of this PR were: These were part of the feature branch when testing. Looking through them, none of them have any changes related to DHIS or data pulling, so should be safe to pull out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RN-588
A bunch of refactors around testing, and then two last commits contain: