Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAUI-1059 Lesmis fetch by entity not country #4121

Merged
merged 2 commits into from
Sep 4, 2022
Merged

MAUI-1059 Lesmis fetch by entity not country #4121

merged 2 commits into from
Sep 4, 2022

Conversation

IgorNadj
Copy link
Contributor

Lesmis map overlays were fetching against the country, changed to fetch against the selected org unit.

Before: https://linear.app/bes/issue/MAUI-1059#comment-75141f0c
After: https://linear.app/bes/issue/MAUI-1059#comment-9b71d1ec

@IgorNadj IgorNadj changed the title Lesmis fetch by entity not country MAUI-1059 Lesmis fetch by entity not country Aug 25, 2022
rohan-bes
rohan-bes reviewed Aug 25, 2022
View reviewed changes
Copy link
Collaborator

@rohan-bes rohan-bes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this break existing map overlays? I think Tupaia also fetches at country level (unless there's a display at level setting...)

@IgorNadj
Copy link
Contributor Author

Will this break existing map overlays? I think Tupaia also fetches at country level (unless there's a display at level setting...)

TBH I'm not sure, from my quick check it seems to work alright. I was going to get a tester to have a look.

rohan-bes
rohan-bes approved these changes Aug 25, 2022
View reviewed changes
Copy link
Collaborator

@rohan-bes rohan-bes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@avaek
Merge pull request #4122 from beyondessential/dev
f3d83fa 
merge latest dev into branch for testing
@IgorNadj IgorNadj merged commit 9cfd2d7 into dev Sep 4, 2022
@IgorNadj IgorNadj deleted the maui-1059-lesmis-fix-fetch branch September 4, 2022 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohan-bes rohan-bes rohan-bes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IgorNadj @rohan-bes @avaek