Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN-646: Add DataTable model to the database #4152

Merged
merged 2 commits into from
Sep 15, 2022
Merged

Conversation

rohan-bes
Copy link
Collaborator

Issue RN-646:

Add the data_table table to the database.

fields:
id: id,
code: human readable unique identifier,
description: what the data table does
type: eg. (sql, google-sheets, transformation, etc.)
config: JSON for the specific data table config
permission_groups: Array of permission group names. Similar to how we do for permissions on data elements. A little conflicted about this, but honestly the permissions model for data tables still needs a bit of working out anyway, so this may just be a placeholder

Copy link
Contributor

@IgorNadj IgorNadj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve, but not sure if you want to just wait until you have a first implementation? I find that implementation details change things quite often. Up to you

@rohan-bes
Copy link
Collaborator Author

Happy to approve, but not sure if you want to just wait until you have a first implementation? I find that implementation details change things quite often. Up to you

@IgorNadj good point! Yeah I never know the best way to go with this kind of stuff 😅 I probably won't merge this one until I've got most of an initial implementation working on my local. But I like to break up the PRs rather than have one beastly one!

* RN-629: Added data-table-server skeleton code

* RN-630: Add Analytics data table (#4159)
@rohan-bes rohan-bes merged commit 9e58433 into dev Sep 15, 2022
@rohan-bes rohan-bes deleted the rn-646-add-data-table-model branch September 15, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants