RN-632: Show Data-Tables in the Admin-Panel #4175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohan-bes
commented
Sep 16, 2022
| @@ -121,6 +122,11 @@ export const ROUTES = [ | |||
| to: '/indicators', | |||
| component: IndicatorsPage, | |||
| }, | |||
| { | |||
| label: 'Data-Tables', | |||
There was a problem hiding this comment.
Do we like this naming style? With the -? I kinda like it as it makes clear that Data-Tables is a single concept, but it's not particularly convention with Tupaia to use -...
There was a problem hiding this comment.
I don't get it sorry 😆
But it's just a label, - or no -, it's a + to me
rohan-bes
commented
Sep 16, 2022
| const getPermissionListWithWildcard = async accessPolicy => { | ||
| const userPermissionGroups = accessPolicy.getPermissionGroups(); | ||
| return ['*', ...userPermissionGroups]; | ||
| }; |
There was a problem hiding this comment.
This code isn't the DRY-est... it's copy pasted from dataElements permissions stuff. It's a bit awkward to consolidate, but I could make more of an effort if the reviewer feels it's worth it
IgorNadj
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue RN-632:
Just display data-tables for now, as we don't want users editing/deleting the internal ones. Next up is to add an interface to view the data-table data in the Admin-Panel in RN-647