Docker lastpass #4528
Merged
Docker lastpass #4528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to be the blessed yarn way now.
Dockerfile is no longer specific to a particular service
Avoids invalidating layer cache and reduces image bloat. Approach courtesy of @passcod.
Fetching env from LastPass to be handled by a separate container.
Remove the devops package from .dockerignore. Scripts from this package are required by CodeShip services containers. This means the devops package is included in the image, which is a little redundant but most likely harmless. Move the Dockerfile out of devops so changes to the Dockerfile don't invalidate the layer cache unnecessarily.
passcod
reviewed
May 4, 2023
Co-authored-by: Félix Saparelli <felix@passcod.name>
IgorNadj
approved these changes
May 16, 2023
IgorNadj
reviewed
May 16, 2023
IgorNadj
reviewed
May 16, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Dockerfile for downloading environment config from LastPass and writing to a directory.
Attempting multiple logins to LastPass from the same IP in succession often results in LastPass blocking the IP for some time. To avoid getting blocked, a "non essential" container can be run in the ECS Task to fetch configuration from LastPass prior to the application containers starting. The configuration is written to a Docker volume which can be mounted into each application container.
The container uses a script slightly modified from scripts/bash/downloadEnvironmentVariables.sh
The following changes have been made to the original script:
By not being in the ../../scripts/bash directory, modifications to this script don't invalidate the Docker cache prior to the application packages build. This was done to speed up development of the script.
Containers running in the ECS task will read env files from a common volume mount. To support this a destination directory needs to be provided as the first argument.
The fallback to 'dev' environments has been removed, if the specified deployment name is missing from the LastPass vault the script will error.