Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-issue: PR template for releases #5270

Merged
merged 10 commits into from
Dec 12, 2023
Merged

no-issue: PR template for releases #5270

merged 10 commits into from
Dec 12, 2023

Conversation

jaskfla
Copy link
Contributor

@jaskfla jaskfla commented Dec 11, 2023

Changes

Created a PR template for releases. After merging, this can (in theory) be invoked using https://github.com/beyondessential/tupaia/compare/master...dev?quick_pull=1&title=Release+20yy-w&labels=release&template=release_template.md, which will also automatically add the release tag.

If an open masterdev PR already exists, GitHub will prompt you to view that one instead of creating a new one.

The existing pull request template remains the default. Unfortunately, this needs to stay at the top level of the ./github folder; moving it into the new ./github/PULL_REQUEST_TEMPLATE folder makes it accessible only via a link with a template query parameter (like the one above).

Testing

This can’t be comprehensively tested until it’s merged into the default branch. Instead, I replicated this template setup in a private repo on my own account, and it seems to work there


Screenshots

None.

@jaskfla
Copy link
Contributor Author

jaskfla commented Dec 11, 2023

After merging, I’ll add a bookmark to the big ugly link to the releases Slack channel

(Probably somewhere appropriate in Slab too)

Copy link
Member

@edmofro edmofro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking initiative here Jasper, awesome

.github/PULL_REQUEST_TEMPLATE/release_template.md Outdated Show resolved Hide resolved
@jaskfla jaskfla requested a review from edmofro December 11, 2023 22:11
Copy link
Member

@edmofro edmofro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jaskfla jaskfla enabled auto-merge (squash) December 12, 2023 00:57
@jaskfla jaskfla merged commit a463b8c into dev Dec 12, 2023
42 checks passed
@jaskfla jaskfla deleted the release-pr-template branch December 12, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants