-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no-issue: PR template for releases #5270
Conversation
After merging, I’ll add a bookmark to the big ugly link to the releases Slack channel (Probably somewhere appropriate in Slab too) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking initiative here Jasper, awesome
suggests not to use leading 0’s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Changes
Created a PR template for releases. After merging, this can (in theory) be invoked using https://github.com/beyondessential/tupaia/compare/master...dev?quick_pull=1&title=Release+20yy-w&labels=release&template=release_template.md, which will also automatically add the release tag.
If an open
master
←dev
PR already exists, GitHub will prompt you to view that one instead of creating a new one.The existing pull request template remains the default. Unfortunately, this needs to stay at the top level of the
./github
folder; moving it into the new./github/PULL_REQUEST_TEMPLATE
folder makes it accessible only via a link with atemplate
query parameter (like the one above).Testing
This can’t be comprehensively tested until it’s merged into the default branch. Instead, I replicated this template setup in a private repo on my own account, and it seems to work there
Screenshots
None.