Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-issue: Odds and sods #5420

Merged
merged 39 commits into from
Feb 19, 2024
Merged

no-issue: Odds and sods #5420

merged 39 commits into from
Feb 19, 2024

Conversation

jaskfla
Copy link
Contributor

@jaskfla jaskfla commented Feb 13, 2024 •
edited
Loading

Changes

  • The first (email) field on Tupaia Web and DataTrak login forms now autofocuses on load. (Saves you a click!)
  • Mostly just edits to READMEs for readability, and to bring small details up-to-date.
  • Some inconsequential UI tweaks, like consistent application of sentence case and minor copy rewordings for succinctness (both according to Material Design style guide). No actual layout changes or anything.

jaskfla
jaskfla commented Feb 13, 2024
View reviewed changes
scripts/bash/buildInternalDependencies.sh Outdated
Copy link
Contributor Author

@jaskfla jaskfla Feb 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks scarier than it is. Just using delimiters ESC[1m and ESC[m to set verbatim bits of commands in bold:

Screenshot 2024-02-12T163851

jaskfla
jaskfla commented Feb 15, 2024
View reviewed changes
packages/database/scripts/checkTestDatabaseExists.sh
Comment on lines +14 to +18
echo -e "\033[31mError: $DB_NAME database does not exist!\033[m"
echo "To create it, get the .env file from LastPass then run:"
echo ""
echo -e " \033[1myarn workspace @tupaia/database setup-test-database\033[m"
echo ""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-02-15T133536

@jaskfla jaskfla marked this pull request as ready for review February 16, 2024 03:45
@jaskfla jaskfla merged commit 183381d into dev Feb 19, 2024
42 checks passed
@jaskfla jaskfla deleted the odds-and-sods branch February 19, 2024 20:58
@jaskfla jaskfla mentioned this pull request Feb 19, 2024
Closed
@avaek avaek mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexd-bes alexd-bes alexd-bes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaskfla @alexd-bes