feat(adminPanel): RN-1301: Enable column resizing #5663
Conversation
There was a problem hiding this comment.
Looks good! Great change!
I reckon this warrants a feat over a tweak 💪
One thing I noticed when playing with it is that it felt a bit easy to accidentally click the header cell and sort the column rather than re-size it. If the sort button was reduced to just the column name (or even just the sort icon) it might feel easier to use. But not sure if that's easy/doable and it's just my opinion so pre-approving 👍
| border: none; | ||
| height: 1px; // need this to make the cell content fill the height of the cell | ||
| position: relative; | ||
| // height: 1px; // need this to make the cell content fill the height of the cell |
There was a problem hiding this comment.
| // height: 1px; // need this to make the cell content fill the height of the cell |
Do we not need this anymore?
| @@ -54,7 +53,8 @@ const COLUMNS = [ | |||
| { | |||
| Header: 'Test', | |||
| type: 'testDatabaseConnection', | |||
| colWidth: '6.5rem', | |||
There was a problem hiding this comment.
Was this not working previously? Or preferring to switch to static width because it's related to expected character lengths of this field?
There was a problem hiding this comment.
Since the columns are resizable, we rely now on react-table to give use the width, and they only support px values, not strings (e.g rems) so have changed to a width and a pixel value instead
alexd-bes
changed the title
Issue RN-1301: Enable column resizing
Changes:
tooltip