refactor: Converted lesmis-server and psss-server to using the @tupaia/api-client
#5681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohan-bes
commented
May 27, 2024
| const countries = await this.entityConnection.fetchCountries(); | ||
| const { accessPolicy } = await this.req.session; |
There was a problem hiding this comment.
This await was unneeded
rohan-bes
force-pushed
the
refactor-lesmis-psss-api-client
branch
from
8ee43ef to
ea2e6b7
Compare
alexd-bes
approved these changes
May 27, 2024
| const { session } = this.req; | ||
| const { entity: entityApi, central: centralApi, report: reportApi } = this.req.ctx.services; | ||
| this.entityConnection = new EntityConnection(entityApi); | ||
| this.centralConnection = new CentralConnection(centralApi, session.email); |
There was a problem hiding this comment.
Maybe a stupid question, but just making sure if there is no session found this won't throw an error trying to access email from undefined?
There was a problem hiding this comment.
I think it should always be defined in this case, since PSSS doesn't support public users, but I'll make it session?.email just in case 👍
rohan-bes
force-pushed
the
refactor-lesmis-psss-api-client
branch
from
0a66c04 to
a4a40a4
Compare
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have been meaning to do this refactor for a long time, finally getting around to it since it blocks fixing RN-1321
Involves removing the deprecated
ApiConnectionclasses, and relying on pulling the@tupaia/api-clientinstead. In the case ofpsss-serverI left the<Service>Connectionclasses, since they provided a nice abstraction on top of the base service.