feat(tupaiaWeb): RN-1304: Date offsets for year granularities #5695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaskfla
reviewed
Jun 5, 2024
| .startOf(value.momentUnit) | ||
| .format(value.rangeFormat); | ||
| const prevEndDate = momentToDateDisplayString( | ||
| moment(END_DATE).add(-1, value.momentShorthand).endOf(value.momentUnit), |
There was a problem hiding this comment.
Suggested change
| moment(END_DATE).add(-1, value.momentShorthand).endOf(value.momentUnit), | |
| moment(END_DATE).subtract(1, value.momentShorthand).endOf(value.momentUnit), |
jaskfla
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Sorry about the delay! I had gotten partway through this and then closed the tab at some point 😅
The complexity here is a bit beyond what I can grasp just by looking at the code, but got nothin’ to complain about in any given part. Do tag Rohan if there’s something you wanted a more rigorous review on
merge: update branch with latest dev before testing
merge: update branch with latest dev
merge: update branch with latest dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue RN-1304: Date offsets for year granularities
Changes:
dateOffsetconfig in dashboard items to allow for offsets to be set for period granularities. Currently only works as expected with year/single year granularities. Assume that there will be unintended results with any other granularity for now.dateRangeDelimiterconfig for dashboard items, which allows a custom delimiter to be set for offset ranges, for single years, e.g.June 2019/May 2020etc. Only applies to single date rangesScreenshots: