Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferred User and Browser Locales #78

Merged
merged 11 commits into from
Apr 1, 2024

Conversation

bezhanSalleh
Copy link
Owner

Copy link

what-the-diff bot commented Jan 25, 2024

PR Summary

  • Simplification of Language Locale Middleware
    The process for handling language locale (identification of user's preferred language) has been simplified in the middleware portion of our application. This means our system can now more effectively understand user preferences when it comes to display language.

  • Improvements to Language Switch Component

    • Introduction of userPreferredLocale attribute: This new attribute allows us to store a user's preferred language setting, either through specific inputs or automated detection.
    • Introduction of preferredLocale attribute: This attribute serves as a system-wide language preference, which can be set manually or via automated preferences.
    • Added methods to update language preferences: Now, both userPreferredLocale and preferredLocale can be quickly changed utilizing two new methods created for this purpose.
    • Improvements to getPreferredLocale method: This method now prioritizes the newly set system-wide preference but falls back to prior preferences logic if none is set, providing a more flexible mechanism in understanding system or user language choice.

This PR helps in improving user experience by being able to cater to their language preferences more smoothly, in turn, enhancing accessibility and personalization.

@bezhanSalleh bezhanSalleh added the enhancement New feature or request label Jan 25, 2024
@aeq-dev
Copy link

aeq-dev commented Mar 17, 2024

Any updates on this? will you merge it? thanks

@dennisvandalen
Copy link

Got here for the SVG bug. Good to see it's already fixed. Thanks @bezhanSalleh!

Any news on when the new version will be released?

@bezhanSalleh
Copy link
Owner Author

Hopefully over the weekend

@bezhanSalleh bezhanSalleh merged commit 29d724e into main Apr 1, 2024
2 checks passed
@bezhanSalleh bezhanSalleh deleted the feature/user-preffered-locale-hook branch April 1, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getBrowserLocale for pt_BR language max-w-none and svg flags
3 participants