Pagination #84
Merged
Pagination #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stanislav Knot <sknot@redhat.com>
MikeEdgar
reviewed
Jun 17, 2021
kafka-admin/src/main/resources/openapi-specs/kafka-admin-rest.yaml
Outdated
Show resolved
Hide resolved
kafka-admin/src/main/java/org/bf2/admin/kafka/admin/handlers/RestOperations.java
Outdated
Show resolved
Hide resolved
kafka-admin/src/main/java/org/bf2/admin/kafka/admin/model/Types.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Stanislav Knot <sknot@redhat.com>
MikeEdgar
reviewed
Jun 17, 2021
kafka-admin/src/main/java/org/bf2/admin/kafka/admin/ConsumerGroupOperations.java
Outdated
Show resolved
Hide resolved
obabec
suggested changes
Jun 17, 2021
systemtests/src/test/java/org/bf2/admin/kafka/systemtest/plain/RestEndpointTestIT.java
Outdated
Show resolved
Hide resolved
systemtests/src/test/java/org/bf2/admin/kafka/systemtest/plain/RestEndpointTestIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Stanislav Knot <sknot@redhat.com>
|
As I expressed at the standup, there's a backward compatibility concern here. we need to be releasing changes that continue to function with the existing callers. We cannot assume that the Console will upgrade at the same moment as Admin API. We cannot assume all instances of the data plane, or all kafka instances are running the same version of the admin API. Thunking required I guess. |
Signed-off-by: Stanislav Knot <sknot@redhat.com>
MikeEdgar
reviewed
Jun 18, 2021
kafka-admin/src/main/java/org/bf2/admin/kafka/admin/TopicOperations.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Stanislav Knot <sknot@redhat.com>
Signed-off-by: Stanislav Knot <sknot@redhat.com>
MikeEdgar
approved these changes
Jun 18, 2021
obabec
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stanislav Knot sknot@redhat.com