Skip to content

Add support for arrays in payload.out to fix build errors #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add support for arrays in payload.out to fix build errors #52

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ba85b5
Add support for arrays in payload.out
garamond Sep 2, 2025
2052b76
Align types
garamond Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions src/lib/sveltify.svelte.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ function single<T extends React.FC | React.ComponentClass>(
* (Mutates target and source objects)
*/
function applyPortals(
$$payload: { out: string },
$$payload: { out: string | string[] },
node: TreeNode,
source: { html: string },
) {
Expand All @@ -255,7 +255,7 @@ function applyPortals(
}

function applyPortal(
$$payload: { out: string },
$$payload: { out: string | string[] },
node: TreeNode,
source: { html: string },
) {
Expand All @@ -281,11 +281,12 @@ function applyPortal(
);

source.html = portal.outerRemoved;
$$payload.out = inject(
const out = inject(
portalTag("svelte", "portal", "target", node.key),
portal.innerHtml,
$$payload.out,
);
$$payload.out = Array.isArray($$payload.out) ? [out] : out;
} catch (err) {
if (!node.parent) {
throw err;
Expand All @@ -294,41 +295,43 @@ function applyPortal(
}
}

function extract(tag: string, html: string) {
function extract(tag: string, html: string | string[]) {
const _html = Array.isArray(html) ? html.join("") : html;
const open = `<${tag}`;
const close = `</${tag}>`;
const position = html.indexOf(open);
const position = _html.indexOf(open);
if (position === -1) {
throw new Error(`Couldn't find '${open}'`);
}
const start = html.indexOf(">", position + open.length) + 1;
const end = html.indexOf(close, start);
const start = _html.indexOf(">", position + open.length) + 1;
const end = _html.indexOf(close, start);
if (end === -1) {
throw new Error(`Couldn't find '${close}'`);
}
const innerHtml = html.substring(start, end);
const innerHtml = _html.substring(start, end);
const outerRemoved =
html.substring(0, start) + html.substring(end + close.length);
_html.substring(0, start) + _html.substring(end + close.length);

return {
innerHtml,
outerRemoved,
};
}

function inject(tag: string, content: string, target: string) {
function inject(tag: string, content: string, target: string | string[]) {
const _target = Array.isArray(target) ? target.join("") : target;
const open = `<${tag}`;
const close = `</${tag}>`;
const position = target.indexOf(open);
const position = _target.indexOf(open);
if (position === -1) {
throw new Error(`Couldn't find ${open}`);
}
const start = target.indexOf(">", position + open.length) + 1;
const start = _target.indexOf(">", position + open.length) + 1;

const end = target.indexOf(close, start);
const end = _target.indexOf(close, start);
if (position === -1) {
throw new Error(`Couldn't find ${close}`);
}

return target.substring(0, start) + content + target.substring(end);
return _target.substring(0, start) + content + _target.substring(end);
}