Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add annotation implement guidance #56

Merged
merged 4 commits into from
Feb 26, 2022
Merged

Add annotation implement guidance #56

merged 4 commits into from
Feb 26, 2022

Conversation

zhugelianglongming
Copy link
Member

Signed-off-by: zhugelianglongming zhugelianglongming@163.com

Docs includes:

  • source code layout
  • core logic
  • annotation implement guide

@zhugelianglongming
Add annotation implement guidance
40af75c 
Signed-off-by: zhugelianglongming <zhugelianglongming@163.com>
daimg
daimg reviewed Feb 22, 2022
View reviewed changes
docs/zh_cn/development/core-logic.md
@@ -0,0 +1,52 @@
# BFE Ingress Controller 工作原理
Copy link
Collaborator

@daimg daimg Feb 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议 ： 工作原理 -> 处理逻辑

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么考虑改成“处理逻辑”？

daimg
daimg reviewed Feb 22, 2022
View reviewed changes
Copy link
Collaborator

@daimg daimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need modification.

@zhugelianglongming
Add code anaysis for annotation implement guidance
d26e7c7 
Signed-off-by: zhugelianglongming <zhugelianglongming@163.com>
@zhugelianglongming
Refine annotation implement guidance according to review comments
12759f4 
Signed-off-by: zhugelianglongming <zhugelianglongming@163.com>
@zhugelianglongming
Refine core logic doc
01a8844 
Signed-off-by: zhugelianglongming <zhugelianglongming@163.com>
@zhugelianglongming zhugelianglongming added the documentation Improvements or additions to documentation label Feb 24, 2022
@daimg daimg merged commit 6fe0bbd into bfenetworks:develop Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarinette9 clarinette9 clarinette9 left review comments

@mileszhang2016 mileszhang2016 Awaiting requested review from mileszhang2016

@daimg daimg Awaiting requested review from daimg

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhugelianglongming @daimg @clarinette9