Add a way to configure Grafana 2 #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a discussion with @bfraser, we decided to introduce a single configuration hash parameter. This allows for any configuration option to be set without relasing a new version (which would be necessary when creating a parameter for each settings). So this allows for more flexicility. Also we decided on using no defaults, since Grafana has sane defaults already. So adding our own defaults would only complicate things.
bfraser
added a commit
that referenced
this pull request
Apr 10, 2015
Add a way to configure Grafana 2
bastelfreak
added a commit
to bastelfreak/puppet-grafana
that referenced
this pull request
Mar 10, 2017
Use operatinsystemmajrelease fact in repo url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a discussion with @bfraser, we decided to introduce a single
configuration hash parameter. This allows for any configuration option
to be set without relasing a new version (which would be necessary when
creating a parameter for each settings). So this allows for more
flexicility.
Also we decided on using no defaults, since Grafana has sane defaults
already. So adding our own defaults would only complicate things.