fix: when direction:rtl style applied, move functions failed to work #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ng testng lintWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix - when direction:rtl style is used (Hebrew in my case) the move functions do not work.
What is the current behavior? (You can also link to an open issue here)
just apply a "direction:rtl" to the style of say the demo page, and you'll see the failed functionality
What is the new behavior (if this is a feature change)?
a quick fix - forcing 'direction:rtl' and flipping the UI did the trick, only thing left was a twirq in position calculation (reversing it) and it did the trick.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no.
Other information:
This should have been a nicer "richer" commit, With changes to move functions according to functionality (moveLeft is actually moving right and vice versa) but hey - it's moving now. It didn't before. Also - with testing - made sure all passed, but didn't add new ones. I just figured it is NOT working today, and it IS working after this quick tiny fix, at least on "my machine", why not push it? I've seen some users requesting it, like Support for RTL direction #270 so figured why not try a PR