fix: Update to 3.1 #385
Merged
fix: Update to 3.1 #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Foundry report forge 0.2.0 (62cdea8 2024-07-23T00:19:34.618350138Z)Build logCompiling 117 files with Solc 0.8.19
Solc 0.8.19 finished in 9.20s
Compiler run successful with warnings:
Warning (2018): Function state mutability can be restricted to pure
--> lib/aave-helpers/src/ProtocolV3TestBase.sol:860:3:
|
860 | function _logReserveConfig(ReserveConfig memory config) internal view {
| ^ (Relevant source part starts here and spans across multiple lines).
| Contract | Size (B) | Margin (B) |
|------------------------------------------------------------|----------|------------|
| AaveV2Avalanche | 45 | 24,531 |
| AaveV2AvalancheAssets | 45 | 24,531 |
| AaveV2Ethereum | 45 | 24,531 |
| AaveV2EthereumAMM | 45 | 24,531 |
| AaveV2EthereumAMMAssets | 45 | 24,531 |
| AaveV2EthereumAssets | 45 | 24,531 |
| AaveV2Polygon | 45 | 24,531 |
| AaveV2PolygonAssets | 45 | 24,531 |
| AaveV3Arbitrum | 45 | 24,531 |
| AaveV3ArbitrumAssets | 45 | 24,531 |
| AaveV3ArbitrumEModes | 45 | 24,531 |
| AaveV3Avalanche | 45 | 24,531 |
| AaveV3AvalancheAssets | 45 | 24,531 |
| AaveV3AvalancheEModes | 45 | 24,531 |
| AaveV3Base | 45 | 24,531 |
| AaveV3BaseAssets | 45 | 24,531 |
| AaveV3BaseEModes | 45 | 24,531 |
| AaveV3Ethereum | 45 | 24,531 |
| AaveV3EthereumAssets | 45 | 24,531 |
| AaveV3EthereumEModes | 45 | 24,531 |
| AaveV3EthereumLido | 45 | 24,531 |
| AaveV3EthereumLidoAssets | 45 | 24,531 |
| AaveV3EthereumLidoEModes | 45 | 24,531 |
| AaveV3EthereumLido_LidoEthereumInstanceActivation_20240720 | 6,780 | 17,796 |
| AaveV3Gnosis | 45 | 24,531 |
| AaveV3GnosisAssets | 45 | 24,531 |
| AaveV3GnosisEModes | 45 | 24,531 |
| AaveV3Optimism | 45 | 24,531 |
| AaveV3OptimismAssets | 45 | 24,531 |
| AaveV3OptimismEModes | 45 | 24,531 |
| AaveV3Polygon | 45 | 24,531 |
| AaveV3PolygonAssets | 45 | 24,531 |
| AaveV3PolygonEModes | 45 | 24,531 |
| Address | 45 | 24,531 |
| ChainHelpers | 45 | 24,531 |
| ChainIds | 45 | 24,531 |
| ConfiguratorInputTypes | 45 | 24,531 |
| Create2Utils | 123 | 24,453 |
| DataTypes | 45 | 24,531 |
| EngineFlags | 45 | 24,531 |
| Errors | 4,673 | 19,903 |
| GovV3Helpers | 2,581 | 21,995 |
| GovV3StorageHelpers | 45 | 24,531 |
| GovernanceV3Arbitrum | 45 | 24,531 |
| GovernanceV3Avalanche | 45 | 24,531 |
| GovernanceV3BNB | 45 | 24,531 |
| GovernanceV3Base | 45 | 24,531 |
| GovernanceV3Ethereum | 45 | 24,531 |
| GovernanceV3Gnosis | 45 | 24,531 |
| GovernanceV3Metis | 45 | 24,531 |
| GovernanceV3Optimism | 45 | 24,531 |
| GovernanceV3Polygon | 45 | 24,531 |
| GovernanceV3PolygonZkEvm | 45 | 24,531 |
| GovernanceV3Scroll | 45 | 24,531 |
| IpfsUtils | 45 | 24,531 |
| MiscEthereum | 45 | 24,531 |
| PayloadsControllerUtils | 45 | 24,531 |
| ProxyHelpers | 45 | 24,531 |
| ReserveConfiguration | 130 | 24,446 |
| RewardsDataTypes | 45 | 24,531 |
| SafeERC20 | 45 | 24,531 |
| StorageHelpers | 45 | 24,531 |
| StringUtils | 45 | 24,531 |
| TestNetChainIds | 45 | 24,531 |
| WadRayMath | 45 | 24,531 |
| WeiConverter | 45 | 24,531 |Test success 🌈No files changed, compilation skipped
Ran 8 tests for src/20240720_AaveV3EthereumLido_LidoEthereumInstanceActivation/AaveV3EthereumLido_LidoEthereumInstanceActivation_20240720.t.sol:AaveV3EthereumLido_LidoEthereumInstanceActivation_20240720_Test
[PASS] test_collectorHasWETHFunds() (gas: 5744360)
[PASS] test_collectorHaswstETHFunds() (gas: 5744406)
[PASS] test_defaultProposalExecution() (gas: 8648747)
Logs:
0x7f39C581F595B53c5cb19bD0b3f8dA6c935E2Ca0
0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2
E2E: Collateral wstETH, TestAsset wstETH
SUPPLY: wstETH, Amount: 24438747489767749446
SUPPLY: wstETH, Amount: 244387474897677494
WITHDRAW: wstETH, Amount: 122193737448838747
WITHDRAW: wstETH, Amount: 122193737448838747
BORROW: wstETH, Amount 244387474897677494, Stable: false
REPAY: wstETH, Amount: 244387474897677494
E2E: Collateral wstETH, TestAsset WETH
SUPPLY: wstETH, Amount: 24438747489767749446
SUPPLY: WETH, Amount: 286716194895701623
WITHDRAW: WETH, Amount: 143358097447850811
WITHDRAW: WETH, Amount: 143358097447850812
BORROW: WETH, Amount 286716194895701623, Stable: false
REPAY: WETH, Amount: 286716194895701623
[PASS] test_deployment_service_fees() (gas: 5731269)
[PASS] test_emissions_admin() (gas: 5746247)
[PASS] test_ethereumAddressesProviderRegistry_registry_lidoAddressesProvider() (gas: 5731192)
[PASS] test_lidoAclManager_roles() (gas: 5733007)
[PASS] test_lidoEthereumAddressesProvider_setAddress_incentivesController_Ethereum() (gas: 5731330)
Suite result: ok. 8 passed; 0 failed; 0 skipped; finished in 11.53s (34.89s CPU time)
Ran 1 test suite in 11.54s (11.53s CPU time): 8 tests passed, 0 failed, 0 skipped (8 total tests) |
* feat: add AaveV3EthereumLido_LidoEthereumInstanceActivation_20240720 * chore: add executor deals in tests * chore: added diffs initial payload * chofix: set seed amount to 0.1 WETH and 0.1 WSTETH * chfix: set LidoEth to assetSymbols, replace emode label to match Aave V3 Ethereum * chorore: update diffs * feat: add lido-eth-v3 to eth-v3 PoolAddressesRegistry, add eth-v3 incentives controller to lido-eth-v3 PoolAddressesProvider * fix: add emission admins, add service fee to Lido Activation Payload * chore: change symbol names to original onesnes, re-run diff with latest version * fix: retrieve WETH AToken via AaveProtocolDataProvider.getReserveTokenAddresses * chore: remove unused constant, add AIP description * chore: describe payload specification and actions * chore: add permissions table link * Update src/20240720_AaveV3EthereumLido_LidoEthereumInstanceActivation/LidoEthereumInstanceActivation.md Co-authored-by: Ernesto Boado <ebdmrr@gmail.com> --------- Co-authored-by: kartojal <david@catapulta.sh> Co-authored-by: Ernesto Boado <ebdmrr@gmail.com>
sakulstra
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.