Skip to content
This repository has been archived by the owner on May 20, 2024. It is now read-only.

🚧 Update Heroku schema #10

Closed
wants to merge 1 commit into from
Closed

🚧 Update Heroku schema #10

wants to merge 1 commit into from

Conversation

catsby
Copy link

@catsby catsby commented Aug 4, 2014

Hey @bgentry!
I checked out the repo, curl'd the latest Heroku schema, and ran gen/gen.rb, but ran into some errors:

$ gen git:schema_update ❯ ./gen.rb 
Loading schema...
Generating account-feature...
Generating account...
Generating addon-service...
Generating addon...
Generating app-feature...
Generating app-setup...
./gen.rb:416:in `resolve_all_propdefs': undefined method `[]' for nil:NilClass (NoMethodError)
    from ./gen.rb:478:in `block in func_arg_comments_from_model_and_link'
    from ./gen.rb:473:in `each'
    from ./gen.rb:473:in `func_arg_comments_from_model_and_link'
    from (erubis:47:in `block in result'
    from (erubis:30:in `each'
    from (erubis:30:in `result'
    from /Users/clint/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/erubis-2.7.0/lib/erubis/evaluator.rb:65:in `eval'
    from /Users/clint/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/erubis-2.7.0/lib/erubis/evaluator.rb:65:in `result'
    from ./gen.rb:555:in `generate_model'
    from ./gen.rb:585:in `block in <main>'
    from ./gen.rb:580:in `each'
    from ./gen.rb:580:in `<main>'

not being familiar with the project too much, I'm not sure if this is due to an issue with the schema, or gen.rb.

I started looking into it with some debugging, but haven't gotten far, so I thought I'd start this with hopes you can easily see what I can't, or at least provide some debugging tips.

@bgentry
Copy link
Owner

bgentry commented Aug 5, 2014

Hey @catsby, there are a number of new JSON schema features used in the latest schemas that my generator never had support for, and they turned out to be quite difficult to add the last time I looked at it. I believe @cyberdelia's heroku-go Is likely the way forward, though somebody has to convert hk to use it (which shouldn't be that much work at all).

@catsby
Copy link
Author

catsby commented Aug 5, 2014

@bgentry ok, thanks for following up. I'll close this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants