Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge bugfixes #1041

Merged
merged 21 commits into from
Oct 11, 2024
Merged

merge bugfixes #1041

merged 21 commits into from
Oct 11, 2024

Conversation

bghira
Copy link
Owner

@bghira bghira commented Oct 11, 2024

No description provided.

bghira and others added 21 commits October 9, 2024 19:20
validations fix for deepspeed
51d9f13
accelerate: allow default_config.yaml to take precedence over config.env
d4e9492
[NTFS] do not crash when filesystem handles deletion in odd ways
b3c286c
deepspeed: resolve error for multinode
cfa6c6e
deepspeed: resolve error for multinode (fix for FA3)
390d43a
local models cannot determine original base_model; fix huggingface hu…
6f5b31e 
…b readme validation error
schnell can be trained w/o fast schedule if user provides --i_know_wh…
2ba13b1 
…at_i_am_doing
add distributed training (multi-node) guide
fa4815c
update readme to guide large cluster operators to the distributed tra…
376293e 
…ining guide
@bghira
correct num_machines / num_processes in demo config
c07d90c
@bghira
fix typo in markdown
b6141ab
@bghira
fix typo in markdown
4f33e6f
add NFS storage example to distributed training guide
01436bf
configure.py should handle utf8 encoding
5db547c
for distributed training we should save rank-specific files in shared…
f0a76fc 
… storage
when saving our state, it should happen using the correct path
d5c62e7
update header txt
a37899d
fix rank retrieval
160ed39
save state on all nodes
0853ad3
disable validations for deepspeed zero3, enable benchmarking for deep…
f7ec503 
…speed zero1 or 2
@bghira
Merge pull request #1040 from bghira/multinode/trainer-state-filenames
d65763e 
multi-node training fixes for state tracker
@bghira bghira merged commit a1fe9ad into release Oct 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bghira