Throw an error if both --flux_schedule_auto_shift and --flux_schedule_shift are enabled. #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_shift are enabled.
|
thanks. i'd been recommending users set one or the other for so long while doing neither by default - i would rather do auto shift by default, but the way the parameters work in python i cannot have a user pass |
bghira
added a commit
that referenced
this pull request
Oct 29, 2024
Fix unit test failure after PR #1106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an alternative to PR #1105, just throw an error if both --flux_schedule_auto_shift and --flux_schedule_shift are enabled, forcing the user to explicitly choose one of them.
Since the default value of --flux_schedule_shift is now 3 after commit 4a7d423, people need to set it 0 if they want to continue training with auto-shift.