Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge #841

Merged
merged 2 commits into from
Aug 22, 2024
Merged

merge #841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb8515b
deepspeed sharding (#840)
bghira Aug 21, 2024
d627c92
fix: only run save full model on main process (#838)
ErwannMillon Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions helpers/training/save_hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,8 @@ def _save_full_model(self, models, weights, output_dir):

def save_model_hook(self, models, weights, output_dir):
# Write "training_state.json" to the output directory containing the training state
if not self.accelerator.is_main_process:
return
StateTracker.save_training_state(
os.path.join(output_dir, "training_state.json")
)
Expand Down
2 changes: 1 addition & 1 deletion train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,7 +873,7 @@ def main():
]["offload_param"]
accelerator.state.deepspeed_plugin.deepspeed_config["zero_optimization"][
"offload_param"
]["pin_memory"] = False
]["pin_memory"] = True
if offload_param["device"] == "nvme":
if offload_param["nvme_path"] == "none":
if args.offload_param_path is None:
Expand Down
Loading