Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure wandb_logs is always defined #896

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

ErwannMillon
Copy link
Contributor

wandb_logs is undefined if accelerator.sync_gradients is False

@bghira
Copy link
Owner

bghira commented Aug 27, 2024

this one is incorrect. you must instantiate it above with the rest of = [] options where the epoch begins.

@bghira bghira merged commit dadc3b6 into bghira:main Aug 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants