netloc: new design #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just needs to disable openat() which doesn't seem allowed inside APK.
This tool permits to show a network in a web browser. This is still a beta version, only for tests.
The nodes can be displayed in different colors depending on the topology found by hwloc.
When saved to json, if gbits is a float, it is not saved as a string (it is the case with int). The problem was solved by converting gbits into a string.
The partition index is used instaed of the pointer.
Better colors, and different sizes for nodes.
And bandwidth added in node info.
Theses problems were memory leaks or so in case of error (for instance in a read file).
When we sort the hash tables, we do not use anymore pointer arithmetic that will have different results on different runs. The tests have been updated to fit the new sort method.
On some machines errno is not set to 0 and since getline returns -1 when EOF it fails.
The new functions permit to build Scotch architectures from the machine or the sub-machine.
netloc.pc and netloc*.h aren't needed since the netloc API isn't public yet. But netloc.h is needed when netlocscotch API is enabled.
It's not directly used yet, but applications will need it for checking netlocscotch error codes.
bgoglin
added a commit
that referenced
this pull request
Oct 26, 2016
netloc: new design The code of Netloc was simplified and cleaned up, with new data types. The main netloc API isn't installed during make install since it may still change in the future. Tools were reorganized under utils/netloc/. A draw tool was added to visualize a topology in a web browser (under utils/netloc/draw/). Netloc can interact with the Scotch partitioning tool by creating Scotch "architectures" from the network topology, and by generating a rank file for MPI from a Scotch mapping. This is the only part of the netloc API that is already public and installed during make install (when scotch is detected).
bgoglin
added a commit
that referenced
this pull request
Oct 26, 2016
netloc: new design The code of Netloc was simplified and cleaned up, with new data types. The main netloc API isn't installed during make install since it may still change in the future. Tools were reorganized under utils/netloc/. A draw tool was added to visualize a topology in a web browser (under utils/netloc/draw/). Netloc can interact with the Scotch partitioning tool by creating Scotch "architectures" from the network topology, and by generating a rank file for MPI from a Scotch mapping. This is the only part of the netloc API that is already public and installed during make install (when scotch is detected). Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
bgoglin
added a commit
that referenced
this pull request
Mar 16, 2018
On a 4-core machine with #2 offline, we want x86 to look at all 4 cores, so that we get info for all online ones (#1, #3 and #4). Before this commit, x86 would only look at the 3 first ones (just like if the offline PUs were always at the end of the range). At least Linux and Solaris can put some CPUs offline in the middle of the index range. So ask hwloc_fallback_nbprocessors() to get the number of existing CPUs. Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code of Netloc was simplified and cleaned up, with new data types. The main netloc API isn't installed during make install since it may still change in the future. Tools were reorganized under utils/netloc/. A draw tool was added to visualize a topology in a web browser (under utils/netloc/draw/). Netloc can interact with the Scotch partitioning tool by creating Scotch "architectures" from the network topology, and by generating a rank file for MPI from a Scotch mapping. This is the only part of the netloc API that is already public and installed during make install (when scotch is detected).