Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug where as4path not used when same length #187

Merged
merged 2 commits into from
Oct 27, 2024

Conversation

digizeph
Copy link
Member

This pull request includes changes to the src/models/bgp/attributes/aspath.rs file to handle different sequence lengths in AS path merging and to add new test cases for these scenarios. The most important changes are:

Handling Different Sequence Lengths:

Adding Test Cases:

Per RFC6793, when aspath and as4path both appears and have the same length, the entirety of as4path should be used.
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.79%. Comparing base (59f05f0) to head (1aa8fd4).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/parser/bmp/messages/route_mirroring.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   92.77%   92.79%   +0.01%     
==========================================
  Files          70       70              
  Lines        8351     8369      +18     
==========================================
+ Hits         7748     7766      +18     
  Misses        603      603              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@digizeph digizeph merged commit 8e8bf4d into main Oct 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant