Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support converting singleton AsSet to Vec<u32> #193

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

digizeph
Copy link
Member

This resolves issue #191

@digizeph digizeph requested a review from Copilot November 22, 2024 04:08
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 suggestion.

Comments skipped due to low confidence (1)

src/models/bgp/attributes/aspath.rs:1272

  • [nitpick] The comment should be more descriptive. Suggested: 'If the path contains any non-convertible segments, it should return None.'
// should the path containing any non-convertable segments, return None

src/models/bgp/attributes/aspath.rs Outdated Show resolved Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.81%. Comparing base (dd12dd7) to head (4a759e7).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
+ Coverage   92.79%   92.81%   +0.02%     
==========================================
  Files          70       70              
  Lines        8369     8409      +40     
==========================================
+ Hits         7766     7805      +39     
- Misses        603      604       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@digizeph digizeph merged commit f73edc6 into main Nov 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant