Communities revisions #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, we have put prefixes like `lg:` or `ecv6` to indicating the exact type of community it is. however, this is not a standard output and users prefer to see just simple colon-separated number strings as community values instead. this is particular the case for large communities where other tools like bgpdump do not have prefixes, making bgpkit-parser output non-comformant to popular tools. this is potentially a breaking change for users who relies on elem outputs instead of matching the actual community values to detect specific community types.
this allows the filtering process to reuse the same regex instead of reconstructing the regex on *every* AS path, which was a very inefficient way of doing filtering.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
==========================================
+ Coverage 92.81% 92.91% +0.09%
==========================================
Files 70 70
Lines 8409 8449 +40
==========================================
+ Hits 7805 7850 +45
+ Misses 604 599 -5 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes aimed at simplifying the display format for BGP communities and enhancing the filtering capabilities with regular expressions. The most important changes are grouped into two themes: display format simplification and filtering enhancements.
Display Format Simplification:
LargeCommunityandExtendedCommunitytypes. Resolves [issue] fix community value representations #169.Filtering Enhancements:
ComparableRegexfor reusable regex-based filters. This partially resolves issue AS path filtering performance #188ComparableRegex. [feature] filter by community values #168