-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lightgbm treeSHAP support #16
Conversation
@bgreenwell : hello Brandon, should I retry to push this LightGBM addon? (I don't think the CI fail is due to my change). |
Hi @mayer79 not sure how I missed this PR. The fail is probably due Travis-CI no longer being supported. I’ll take a look at this PR in the next couple of days. Thanks a lot!! 🙏 |
No problem at all :-). Thanks a lot for looking into this. |
Hey @mayer79, sorry for the inconvenience, but would you mind submitting a PR for this new version? If not, I can easily grab your changes and just throw them in manually. Whatever is easiest. |
No issue at all! I repushed but there are some conflicts. As I don't have the permission to resolve them, we can do two things:
|
@mayer79 I ended up just manually pulling in most of the changes and crediting your contribution in the NEWS file (hope that's OK); my git skills are questionable when it comes to merging with conflicts :/ Let me know if the new changes do not work on your end and thanks a bunch for this valuable contribution! (Always looking for help :) |
Perfect fine. Thanks for the extra work! |
Hello
I added a draft for supporting LightGBM's internal TreeSHAP algo, solving #15
Example
Let me know if something feels odd please.