Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sylph tool Wrapper #1518
base: master
Are you sure you want to change the base?
Sylph tool Wrapper #1518
Changes from 18 commits
027c8be
d7fc0e7
6146fb0
f1e4551
6b9d9cb
55d54f1
3519a0b
8944a8d
63ca10f
46e5d68
477e325
25d9bac
1513faf
691a915
9221bb8
d86bcf0
3c35f6f
5566c61
21de493
3fae5b1
da2821f
2dfa011
bdc5e02
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add here a filter for version
1
or something like that ... and then we include version 1 in the test file.Whenever the tool changes to DB layout we increase this version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping, you are not filtering the DB here according to the version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is
database_select.metadata
?Is this piece tested?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of the way sylph works, it has two separate bits of data it works with -- the database itself, and the metadatafile associated with it. The metadata file MUST be the same one associated with the database, otherwise it will not work. Because of that, we set up the database file to be a directory endpoint with the intent that that directory would hold the db and the associated metadata file. In this case, if a user wants to select it from the history, we added a secondary param to the history part that lets a user optionally add that metadata file, should they want to run that part of the tool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
database_select = history is not tested agaik