Service account tests

app/lib/server/functions/notifications/serviceAccount.js

@@ -0,0 +1,27 @@
+import { metrics } from '../../../../metrics';
+import { Notifications } from '../../../../notifications';
+
+export function shouldNotifyServiceAccountOwner({
+	hasMentionToAll,
+	hasMentionToHere,
+	isHighlighted,
+	hasMentionToUser,
+	hasReplyToThread,
+	roomType,
+}) {
+	return roomType === 'd' || hasMentionToAll || hasMentionToHere || isHighlighted || hasMentionToUser || hasReplyToThread;
+}
+
+export function notifyServiceAccountOwner(receiver, ownerId, message, room) {
+	metrics.notificationsSent.inc({ notification_type: 'sa' });
+	Notifications.notifyUser(ownerId, 'sa-notification', {
+		payload: {
+			_id: message._id,
+			rid: message.rid,
+			sender: message.u,
+			receiver: receiver.username,
+			type: room.t,
+			name: room.name,
+		},
+	});
+}

app/lib/server/lib/sendNotificationsOnMessage.js

@@ -11,6 +11,7 @@ import { sendEmail, shouldNotifyEmail } from '../functions/notifications/email';
 import { sendSinglePush, shouldNotifyMobile } from '../functions/notifications/mobile';
 import { notifyDesktopUser, shouldNotifyDesktop } from '../functions/notifications/desktop';
 import { notifyAudioUser, shouldNotifyAudio } from '../functions/notifications/audio';
+import { notifyServiceAccountOwner, shouldNotifyServiceAccountOwner } from '../functions/notifications/serviceAccount';
 
 export const sendNotification = async ({
 	subscription,
@@ -46,6 +47,7 @@ export const sendNotification = async ({
 					status: 1,
 					statusConnection: 1,
 					username: 1,
+					u: 1,
 				},
 			}),
 		];
@@ -149,6 +151,17 @@ export const sendNotification = async ({
 			return false;
 		});
 	}
+
+	if (receiver.u && shouldNotifyServiceAccountOwner({
+		hasMentionToAll,
+		hasMentionToHere,
+		isHighlighted,
+		hasMentionToUser,
+		hasReplyToThread,
+		roomType,
+	})) {
+		notifyServiceAccountOwner(receiver, receiver.u._id, message, room);
+	}
 };
 
 const project = {
@@ -168,6 +181,7 @@ const project = {
 		'receiver.status': 1,
 		'receiver.statusConnection': 1,
 		'receiver.username': 1,
+		'receiver.u': 1,
 	},
 };
 

app/service-accounts/client/stylesheets/serviceAccounts.css

@@ -0,0 +1,43 @@
+.rc-service-account-list {
+	&__user {
+
+		display: flex;
+
+		padding: 8px 0;
+
+		cursor: pointer;
+		align-items: center;
+
+		&.active,
+		&:hover {
+			background-color: #eeeeee;
+
+			& .rc-member-list__menu {
+				opacity: 1;
+			}
+		}
+
+		& > .avatar {
+			width: var(--sidebar-account-thumb-size);
+			height: var(--sidebar-account-thumb-size);
+		}
+	}
+
+	&__username {
+		display: flex;
+		flex: 1 1 auto;
+
+		margin: 0 12px 0 8px;
+
+		font-size: 16px;
+		align-items: center;
+	}
+
+	&__username-alert {
+		font-weight: bold;
+	}
+}
+
+.service-account-notification {
+	color: var(--rc-color-alert-message-primary-background);
+}

app/service-accounts/client/views/serviceAccountSidebarLogin.html

@@ -1,26 +1,39 @@
 <template name="serviceAccountSidebarLogin">
 	<div class="rc-popover__column">
 		<ul class="rc-popover__list">
-			{{#if showOwnerAccountLink}}
-				<p>Go back to main account</p>
-				<li class='rc-member-list__user js-login'>
-					{{> avatar username=owner.username}}
-					<div class="rc-member-list__username">
-						{{owner.username}}
-					</div>
-				</li>
+			{{#if loading}}
+				<p>Loading ... </p>
 			{{else}}
-				{{#if hasServiceAccounts}}
-					{{#each users}}
-						<li class='rc-member-list__user js-login'>
-							{{> avatar username=username}}
-							<div class="rc-member-list__username">
-								{{username}}
-							</div>
-						</li>
-					{{/each}}
+				{{#if showOwnerAccountLink}}
+					<p>Go back to main account</p>
+					<li class='rc-service-account-list__user js-login'>
+						{{> avatar username=owner.username}}
+						<div class="rc-service-account-list__username">
+							{{owner.username}}
+						</div>
+					</li>
 				{{else}}
-					<p>{{_ "You_have_no_service_accounts"}}</p>
+					{{#if hasServiceAccounts}}
+						{{#each users}}
+							<li class='rc-service-account-list__user js-login'>
+								{{> avatar username=username}}
+								<div class="rc-service-account-list__username">
+									{{#if receivedNewMessage username}}
+										<span class="rc-service-account-list__username-alert">
+											{{username}}
+										</span>
+									{{else}}
+										{{username}}
+									{{/if}}
+								</div>
+								<div class="badge">
+									{{unread}}
+								</div>
+							</li>
+						{{/each}}
+					{{else}}
+						<p>{{_ "You_have_no_service_accounts"}}</p>
+					{{/if}}
 				{{/if}}
 			{{/if}}
 		</ul>

app/service-accounts/client/views/serviceAccountSidebarLogin.js

@@ -1,30 +1,36 @@
 import { Meteor } from 'meteor/meteor';
 import { ReactiveVar } from 'meteor/reactive-var';
 import { Template } from 'meteor/templating';
+import { FlowRouter } from 'meteor/kadira:flow-router';
+import { Session } from 'meteor/session';
 
 import { handleError } from '../../../utils';
 import { callbacks } from '../../../callbacks';
-import FullUser from '../../../models/client/models/FullUser';
 import './serviceAccountSidebarLogin.html';
 import { popover } from '../../../ui-utils/client';
 
 Template.serviceAccountSidebarLogin.helpers({
-	isReady() {
-		const instance = Template.instance();
-		return instance.ready && instance.ready.get();
+	loading() {
+		return Template.instance().loading.get();
 	},
 	users() {
-		return Template.instance().users();
+		return Template.instance().users.get();
 	},
 	hasServiceAccounts() {
-		return Template.instance().users() && Template.instance().users().length > 0;
+		return Template.instance().users.get() && Template.instance().users.get().length > 0;
 	},
 	owner() {
 		return Meteor.user() && Meteor.user().u;
 	},
 	showOwnerAccountLink() {
 		return localStorage.getItem('serviceAccountForceLogin') && Meteor.user() && !!Meteor.user().u;
 	},
+	receivedNewMessage(username) {
+		if (Template.instance().notifiedServiceAccount) {
+			return username === Template.instance().notifiedServiceAccount.get();
+		}
+		return false;
+	},
 });
 
 Template.serviceAccountSidebarLogin.events({
@@ -62,16 +68,21 @@ Template.serviceAccountSidebarLogin.events({
 Template.serviceAccountSidebarLogin.onCreated(function() {
 	const instance = this;
 	this.ready = new ReactiveVar(true);
+	this.users = new ReactiveVar([]);
+	this.loading = new ReactiveVar(true);
+	this.notifiedServiceAccount = new ReactiveVar('');
+	instance.notifiedServiceAccount.set(Session.get('saMessageReceiver'));
+	Session.delete('saMessageReceiver');
+	Session.delete('saNotification');
 	this.autorun(() => {
-		const subscription = instance.subscribe('userServiceAccounts');
-		instance.ready.set(subscription.ready());
+		instance.loading.set(true);
+		Meteor.call('getLinkedServiceAccounts', function(err, serviceAccounts) {
+			if (err) {
+				this.loading.set(false);
+				return handleError(err);
+			}
+			instance.users.set(serviceAccounts);
+			instance.loading.set(false);
+		});
 	});
-	this.users = function() {
-		const query = {
-			'u._id': Meteor.userId(),
-			active: true,
-		};
-		const limit = instance.limit && instance.limit.get();
-		return FullUser.find(query, { limit, sort: { username: 1, name: 1 } }).fetch();
-	};
 });

app/service-accounts/server/api/v1/serviceAccounts.js

@@ -18,3 +18,32 @@ API.v1.addRoute('serviceAccounts.create', { authRequired: true }, {
 		return API.v1.success({ user: Users.findOneByUsername(this.bodyParams.username, { fields: API.v1.defaultFieldsToExclude }) });
 	},
 });
+
+API.v1.addRoute('serviceAccounts.getLinkedAccounts', { authRequired: true }, {
+	get() {
+		let serviceAccounts;
+		Meteor.runAsUser(this.userId, () => {
+			serviceAccounts = Meteor.call('getLinkedServiceAccounts');
+		});
+
+		if (!serviceAccounts) {
+			return API.v1.failure();
+		}
+		return API.v1.success({ serviceAccounts });
+	},
+});
+
+API.v1.addRoute('serviceAccounts.getToken', { authRequired: true }, {
+	get() {
+		const { username } = this.queryParams;
+		let token;
+		Meteor.runAsUser(this.userId, () => {
+			token = Meteor.call('getLoginToken', username);
+		});
+
+		if (!token) {
+			return API.v1.failure();
+		}
+		return API.v1.success({ token });
+	},
+});

app/service-accounts/server/index.js

@@ -6,11 +6,11 @@ import './api/rest';
 import './methods/usernameExists';
 import './methods/addServiceAccount';
 import './methods/getLoginToken';
+import './methods/getLinkedServiceAccounts';
 
 import './hooks/serviceAccountCallback';
 import './hooks/serviceAccountBroadcast';
 
 import './publications/fullServiceAccountData';
-import './publications/userServiceAccounts';
 
 import '../lib/serviceAccountRoomType';

app/service-accounts/server/methods/getLinkedServiceAccounts.js

@@ -0,0 +1,22 @@
+import { Meteor } from 'meteor/meteor';
+
+import { Users, Subscriptions } from '../../../models';
+import { getDefaultUserFields } from '../../../utils/server/functions/getDefaultUserFields';
+
+Meteor.methods({
+	getLinkedServiceAccounts() {
+		if (!Meteor.userId()) {
+			throw new Meteor.Error('error-invalid-user', 'Invalid user', { method: 'addServiceAccount' });
+		}
+
+		const query = {
+			'u._id': Meteor.userId(),
+			active: true,
+		};
+		const result = Users.find(query, { fields: getDefaultUserFields() }).fetch();
+		result.forEach((serviceAccount) => {
+			serviceAccount.unread = Subscriptions.findUnreadByUserId(serviceAccount._id).count();
+		});
+		return result;
+	},
+});

app/ui-sidenav/client/sidebarHeader.html

@@ -7,8 +7,14 @@
 			</div>
 			<div class="sidebar__toolbar">
 				{{#each toolbarButtons}}
-					<button class="sidebar__toolbar-button rc-tooltip rc-tooltip--down js-button" aria-label="{{name}}">
-						{{> icon block="sidebar__toolbar-button-icon" icon=icon }}
+					<button class=" sidebar__toolbar-button  rc-tooltip rc-tooltip--down js-button" aria-label="{{name}}">
+						{{#if active}} 
+							<span class="service-account-notification">
+								{{> icon block="sidebar__toolbar-button-icon" icon=icon }}
+							</span>
+						{{else}}
+							{{> icon block="sidebar__toolbar-button-icon" icon=icon }}
+						{{/if}}
 					</button>
 				{{/each}}
 			</div>

app/ui-sidenav/client/sidebarHeader.js

@@ -2,6 +2,7 @@ import { Meteor } from 'meteor/meteor';
 import { ReactiveVar } from 'meteor/reactive-var';
 import { FlowRouter } from 'meteor/kadira:flow-router';
 import { Template } from 'meteor/templating';
+import { Session } from 'meteor/session';
 
 import { popover, AccountBox, menu, SideNav, modal } from '../../ui-utils';
 import { t, getUserPreference, handleError } from '../../utils';
@@ -74,6 +75,7 @@ const toolbarButtons = (user) => [{
 {
 	name: t('Service_account_login'),
 	icon: 'reload',
+	active: Session.get('saNotification'),
 	condition: () => (Meteor.user() && !Meteor.user().u) || (Meteor.user() && Meteor.user().u && localStorage.getItem('serviceAccountForceLogin')),
 	action: (e) => {
 		const options = [];

client/importsCss.js

@@ -38,3 +38,4 @@ import '../app/ui-vrecord/client/vrecord.css';
 import '../app/videobridge/client/stylesheets/video.less';
 import '../app/wordpress/client/wordpress-login-button.css';
 import '../app/katex/katex.min.css';
+import '../app/service-accounts/client/stylesheets/serviceAccounts.css';

client/notifications/notification.js

@@ -82,6 +82,11 @@ Meteor.startup(function() {
 			Notifications.onUser('subscriptions-changed', (action, sub) => {
 				notifyNewRoom(sub);
 			});
+
+			Notifications.onUser('sa-notification', (notification) => {
+				Session.set('saNotification', true);
+				Session.set('saMessageReceiver', notification.payload.receiver);
+			});
 		}
 	});
 });