A Big effort to create a conforming c++ version #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even got some pybind11 going so that I can eventually use the same tests as exist in the python. Potentially could even phase out the python module code, or leave it as a reference.
I can use "test_vector.py" unaltered, and I'm hopeful that I can continue that trend for all the python tests until the bindings and c++ classes are complete.
Tuples are getting in my way.
Took some massaging, but overall I like it better.
This is now much cleaner, which I like.
Deals with converting tuple usage to Point2d
The module still needs the raster function, however.
It doesn't quite work yet in c++. There seem to be gaps of some kind either related to angle or nudging. Evidence based on adding a new simple circle test in "test_raster.py".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While originally I had intended to leave the python as is, in the course of attempting it, I found that factoring the python helped the effort considerably. I've found this very instructive, as more evidence that interfaces must always require good behavior from both sides for best maintenance.