use DjangoJSONEncoder on ArrayFormField to support datetime, UUID, Decimal, etc. #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I think instead of writing our own encoder class, we should just use Django provided |
bhch
reviewed
Feb 4, 2024
There was a problem hiding this comment.
Thanks for the PR.
I think instead of writing our own encoder class, we should just use Django provided DjangoJSONEncoder. It will take care of encoding other objects as well such as datetime.
If you could update your PR with those changes, it would be great.
nullcode
changed the title
|
sure, makes sense @bhch , updated the PR. |
|
Released in v2.22.0. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current JSONEncoder would throw "Object of type Decimal is not JSON serializable" if you are using the libraries' ArrayField with a base_field of models.DecimalField().
This is a fix for that.
from django_jsonform.models.fields import ArrayFieldexample = ArrayField(models.DecimalField(decimal_places=2, max_digits=5))