Enable whitespace selection in choices #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsnolan23
approved these changes
Jul 10, 2024
|
Here's a link to when this was introduced, to me this indicates the empty validation was all this was needed for. |
|
Thank you for this fix. Will release soon. |
|
Released in v2.23.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A string type with a choice that contains whitespace on the outer part cannot be selected, or it will generate an error. See the modified test for an example.
To fix this, I utilize the stripped/trimmed version of the string value only for validating whether the field is empty, otherwise the raw value is used.