#593: correct tests

bhecquet · Mar 12, 2024 · 515a5d5 · 515a5d5
1 parent a348299
commit 515a5d5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/core/src/test/java/com/seleniumtests/ut/browserfactory/TestBrowserInfo.java b/core/src/test/java/com/seleniumtests/ut/browserfactory/TestBrowserInfo.java
@@ -79,8 +79,8 @@ public void testWrongPath() {
 	@Test(groups={"ut"})
 	public void testEdgeVersion() {
 		if (SystemUtils.IS_OS_WINDOWS) {
-			BrowserInfo bInfo = new BrowserInfo(BrowserType.EDGE, "115.0", null);
-			Assert.assertEquals(bInfo.getDriverFileName(), "edgedriver_115.0_edge-115-116");
+			BrowserInfo bInfo = new BrowserInfo(BrowserType.EDGE, "122.0", null);
+			Assert.assertEquals(bInfo.getDriverFileName(), "edgedriver_122.0_edge-122-123");
 		}
 	}
 

diff --git a/core/src/test/java/com/seleniumtests/ut/core/TestLogActions.java b/core/src/test/java/com/seleniumtests/ut/core/TestLogActions.java
@@ -232,7 +232,7 @@ public void testLogNativeSeleniumElementActionNoOverride() throws Exception {
 		Assert.assertTrue(clickAction.getName().contains("click on Element located by"));
 		Assert.assertEquals(clickAction.getPage(), DriverTestPageNativeActions.class);
 		Assert.assertTrue(clickAction.getElement() instanceof SeleniumElement);
-		Assert.assertNull(clickAction.getElement().getCallingPage());	// calling page is null for native WebElements
+		Assert.assertTrue(clickAction.getElement().getCallingPage() instanceof DriverTestPageNativeActions);
 		Assert.assertEquals(clickAction.getElement().getOrigin(), "com.seleniumtests.it.driver.support.pages.DriverTestPageNativeActions");
 		Assert.assertNull(clickAction.getElement().getFieldName()); // null as created inline
 		Assert.assertNotNull(clickAction.getElement().getName());
@@ -257,7 +257,7 @@ public void testLogPageFactorySeleniumElementActionNoOverride() throws Exception
 		Assert.assertEquals(clickAction.getPage(), DriverTestPageObjectFatory.class);
 		Assert.assertTrue(clickAction.getElement() instanceof SeleniumElement);
 		Assert.assertEquals(clickAction.getElement().getOrigin(), "com.seleniumtests.it.driver.support.pages.DriverTestPageObjectFatory");
-		Assert.assertNull(clickAction.getElement().getCallingPage());	// calling page is null for native WebElements
+		Assert.assertTrue(clickAction.getElement().getCallingPage() instanceof DriverTestPageObjectFatory);
 		Assert.assertNull(clickAction.getElement().getFieldName()); // null as we don't support field name for page factory elements
 																	// this could be possible as elements are initialized on page creation,
 																	// but this is a marginal use case, so we ignore it deliberately

diff --git a/core/src/test/java/com/seleniumtests/ut/reporter/logger/TestTestStep.java b/core/src/test/java/com/seleniumtests/ut/reporter/logger/TestTestStep.java
@@ -744,7 +744,7 @@ public void testToJsonWithException() throws IOException {
 		JSONObject stepJson = step.toJson();
 
 		Assert.assertEquals(stepJson.getString("type"), "step");
-		Assert.assertEquals(stepJson.getString("exception"), "class org.openqa.selenium.WebDriverException");
+		Assert.assertEquals(stepJson.getString("exception"), "org.openqa.selenium.WebDriverException");
 		Assert.assertTrue(stepJson.getString("exceptionMessage").contains("class org.openqa.selenium.WebDriverException: KO"));
 		Assert.assertEquals(stepJson.getString("name"), "step1");
 		Assert.assertEquals(stepJson.getString("status"), "WARNING");